Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UT for SR Obfuscators #2031

Merged
merged 1 commit into from
May 13, 2024
Merged

Improve UT for SR Obfuscators #2031

merged 1 commit into from
May 13, 2024

Conversation

xgouchet
Copy link
Member

What does this PR do?

Improve the UT regarding the obfuscators to be more exhaustive

@xgouchet xgouchet requested review from a team as code owners May 13, 2024 10:34
@xgouchet xgouchet force-pushed the xgouchet/sr_ut_obfuscators branch from 803d45b to 4ad6c3c Compare May 13, 2024 10:58
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.39%. Comparing base (3d0a4d2) to head (4ad6c3c).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2031      +/-   ##
===========================================
+ Coverage    83.31%   83.39%   +0.07%     
===========================================
  Files          485      485              
  Lines        17671    17671              
  Branches      2685     2685              
===========================================
+ Hits         14722    14735      +13     
+ Misses        2213     2200      -13     
  Partials       736      736              
Files Coverage Δ
...al/recorder/obfuscator/AndroidNStringObfuscator.kt 77.78% <100.00%> (ø)

... and 25 files with indirect coverage changes

Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one! happy to see Unicode supplementary planes coverage

override fun obfuscate(stringValue: String): String {
return buildString {
return buildString(stringValue.length) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice idea with pre-allocation

@xgouchet xgouchet merged commit 20de109 into develop May 13, 2024
21 checks passed
@xgouchet xgouchet deleted the xgouchet/sr_ut_obfuscators branch May 13, 2024 12:53
@xgouchet xgouchet added this to the 2.10.x milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants