Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4413 Add telemetry on SR resources track #2027

Merged
merged 1 commit into from
May 13, 2024

Conversation

xgouchet
Copy link
Member

What does this PR do?

In order to better read the performance of the Image Resource upload for Session Replay, we add the telemetry on batch deleted/closed/expired with a dedicated track name.

@xgouchet xgouchet requested review from a team as code owners May 10, 2024 07:23
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.34%. Comparing base (ddf2286) to head (b5d0296).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2027      +/-   ##
===========================================
+ Coverage    83.17%   83.34%   +0.18%     
===========================================
  Files          486      486              
  Lines        17633    17670      +37     
  Branches      2680     2687       +7     
===========================================
+ Hits         14665    14727      +62     
+ Misses        2232     2201      -31     
- Partials       736      742       +6     
Files Coverage Δ
.../kotlin/com/datadog/android/api/feature/Feature.kt 100.00% <ø> (ø)
...id/core/internal/metrics/BatchMetricsDispatcher.kt 98.61% <100.00%> (+0.02%) ⬆️

... and 27 files with indirect coverage changes

/**
* Session Replay Resources sub-feature name.
*/
const val SESSION_REPLAY_RESOURCES_FEATURE_NAME: String = "session-replay-resources"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By adding this here, the feature name for Resources is now defined in two places - in Feature and also in the feature itself. I notice that this is also the case for Session Replay. Do we want to consolidate both of them to use only the constants from Feature and have a SST?

@xgouchet xgouchet merged commit 7566da7 into develop May 13, 2024
21 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-4413/resource_track_telemetry branch May 13, 2024 07:40
@xgouchet xgouchet added this to the 2.10.x milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants