RUM-4148 Add support to the Toolbar in Session Replay #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2024 +/- ##
===========================================
- Coverage 83.55% 83.51% -0.04%
===========================================
Files 478 482 +4
Lines 17576 17586 +10
Branches 2672 2671 -1
===========================================
+ Hits 14684 14686 +2
- Misses 2164 2171 +7
- Partials 728 729 +1
|
0xnm
approved these changes
May 2, 2024
...replay/src/main/kotlin/com/datadog/android/sessionreplay/internal/DefaultRecorderProvider.kt
Show resolved
Hide resolved
| import android.annotation.SuppressLint | ||
| import android.graphics.drawable.Drawable | ||
|
|
||
| internal class ActionBarContainerDrawableAccessor( |
There was a problem hiding this comment.
minor: maybe add Datadog to the name? unlikely that the class named ActionBarContainerDrawableAccessor will ever appear in Android codebase, but who knows.
| // ActionBarContainer class. | ||
| // Fortunately, the mBackground field we're interested in is package private, | ||
| // which allows us to access it. | ||
| // val background = backgroundField?.get(view) as? Drawable |
| val shapeStyle = background?.let { resolveShapeStyle(it, view.alpha) } | ||
| val id = viewIdentifierResolver.resolveChildUniqueIdentifier(view, PREFIX_BACKGROUND_DRAWABLE) | ||
|
|
||
| if ((shapeStyle != null) && (id != null)) { |
| } | ||
|
|
||
| @SuppressLint("RestrictedApi") | ||
| fun setBackgroundDrawabal(drawable: Drawable) { |
There was a problem hiding this comment.
typo in the method name
Suggested change
| fun setBackgroundDrawabal(drawable: Drawable) { | |
| fun setBackgroundDrawable(drawable: Drawable) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR allows sessin replay to capture the content of a Toolbar.
ActionBarContainer's background