Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-4418: Don't mark internal extension functions for 3rd party types as 3rd party #1996

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Apr 17, 2024

What does this PR do?

Fix for the long-standing issue: UnsafeThirdPartyFunctionCall was marking internal extension functions for third-party types as third-party functions, which is wrong. This PR fixes that by checking the declaration package for the function in addition to its container.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners April 17, 2024 13:04
@0xnm 0xnm force-pushed the nogorodnikov/rum-4118/dont-mark-internal-extension-functions-for-3rd-party-types-as-3rd-party branch from 462b42b to 4f4ebb2 Compare April 17, 2024 13:06
Copy link
Member

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work thanks

@0xnm 0xnm force-pushed the nogorodnikov/rum-4118/dont-mark-internal-extension-functions-for-3rd-party-types-as-3rd-party branch from 4f4ebb2 to 9263a25 Compare April 17, 2024 13:29
@codecov-commenter
Copy link

Codecov Report

Merging #1996 (9263a25) into develop (18967d7) will decrease coverage by 0.01%.
Report is 12 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1996      +/-   ##
===========================================
- Coverage    83.66%   83.65%   -0.01%     
===========================================
  Files          488      488              
  Lines        17770    17730      -40     
  Branches      2663     2661       -2     
===========================================
- Hits         14867    14832      -35     
+ Misses        2178     2177       -1     
+ Partials       725      721       -4     

see 29 files with indirect coverage changes

@0xnm 0xnm merged commit 4835ae6 into develop Apr 17, 2024
22 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-4118/dont-mark-internal-extension-functions-for-3rd-party-types-as-3rd-party branch April 17, 2024 14:30
@xgouchet xgouchet added this to the 2.9.X milestone Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants