Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mime type for nightly tests #1936

Merged
merged 1 commit into from
Mar 25, 2024
Merged

Fix mime type for nightly tests #1936

merged 1 commit into from
Mar 25, 2024

Conversation

jonathanmos
Copy link
Member

What does this PR do?

The mimetype was removed in the refactor pr and this is breaking the nightly tests. This pr removes the mimetype from the payload jsons

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos jonathanmos marked this pull request as ready for review March 25, 2024 13:06
@jonathanmos jonathanmos requested review from a team as code owners March 25, 2024 13:06
@jonathanmos jonathanmos merged commit f3e10ae into develop Mar 25, 2024
23 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/fix-mimetype-for-nightlytests branch March 25, 2024 13:31
@xgouchet xgouchet added this to the 2.8.x milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.x
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathanmos @0xnm @xgouchet