Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent ConcurrentModificationException when reading feature flags #1925

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Mar 20, 2024

What does this PR do?

Small change to prevent ConcurrentModificationException which may happen when feature flags are read during ErrorEvent serialization on the worker thread.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners March 20, 2024 13:28
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Merging #1925 (e47a102) into develop (12e4b09) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1925      +/-   ##
===========================================
+ Coverage    83.34%   83.39%   +0.05%     
===========================================
  Files          481      481              
  Lines        17408    17398      -10     
  Branches      2589     2588       -1     
===========================================
  Hits         14508    14508              
+ Misses        2193     2182      -11     
- Partials       707      708       +1     
Files Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 93.36% <100.00%> (+0.01%) ⬆️

... and 25 files with indirect coverage changes

Copy link
Member

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, do you think you can add a Unit Test to verify we don't remove this in the future?

@0xnm
Copy link
Member Author

0xnm commented Mar 21, 2024

@xgouchet Good idea! I will do it then in another PR, because I want this change to be shipped with upcoming release.

@0xnm 0xnm merged commit 881b115 into develop Mar 21, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/prevent-concurrent-modification-exception-when-reading-feature-flags branch March 21, 2024 07:57
@xgouchet xgouchet added this to the 2.7.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants