Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-3523: Report all threads for non-fatal ANRs #1912

Merged

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Mar 13, 2024

What does this PR do?

This PR adds reporting of all threads information for non-fatal ANRs, threads are reported in the same manner as it was done before for crashes (meaning name, state, stacktrace will be reported).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners March 13, 2024 10:15
@0xnm 0xnm force-pushed the nogorodnikov/rum-3523/report-all-threads-for-non-fatal-anrs branch from cb25673 to 1cbed8f Compare March 13, 2024 13:22
Copy link
Member

@mariusc83 mariusc83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some not blocking comments for me. All seems ok there.

@codecov-commenter
Copy link

Codecov Report

Merging #1912 (1cbed8f) into develop (f46eb76) will increase coverage by 0.01%.
Report is 6 commits behind head on develop.
The diff coverage is 78.12%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1912      +/-   ##
===========================================
+ Coverage    83.38%   83.39%   +0.01%     
===========================================
  Files          477      477              
  Lines        16922    16985      +63     
  Branches      2514     2524      +10     
===========================================
+ Hits         14109    14164      +55     
- Misses        2120     2126       +6     
- Partials       693      695       +2     
Files Coverage Δ
...m/datadog/android/core/internal/utils/ThreadExt.kt 62.50% <100.00%> (ø)
...in/kotlin/com/datadog/android/rum/RumAttributes.kt 0.00% <ø> (ø)
.../android/rum/internal/monitor/DatadogRumMonitor.kt 84.62% <100.00%> (+0.10%) ⬆️
...og/android/rum/internal/anr/ANRDetectorRunnable.kt 85.19% <74.07%> (-8.15%) ⬇️

... and 25 files with indirect coverage changes

@0xnm 0xnm merged commit 0f9e699 into develop Mar 15, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-3523/report-all-threads-for-non-fatal-anrs branch March 15, 2024 09:05
@xgouchet xgouchet added this to the 2.7.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants