Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-3276: Fix image resizing issue #1897

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

jonathanmos
Copy link
Member

@jonathanmos jonathanmos commented Mar 3, 2024

What does this PR do?

Fixes a resizing issue due to setbounds on the drawable. We need to perform this operation on a copy of the drawable to avoid modifying the viewtree.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

Merging #1897 (b8802bd) into develop (30135fa) will increase coverage by 0.12%.
The diff coverage is 95.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1897      +/-   ##
===========================================
+ Coverage    83.31%   83.43%   +0.12%     
===========================================
  Files          477      477              
  Lines        16864    16926      +62     
  Branches      2504     2514      +10     
===========================================
+ Hits         14050    14122      +72     
+ Misses        2122     2120       -2     
+ Partials       692      684       -8     
Files Coverage Δ
...nternal/recorder/resources/ImageWireframeHelper.kt 95.45% <100.00%> (+0.29%) ⬆️
...internal/recorder/resources/ResourcesSerializer.kt 98.01% <100.00%> (+0.08%) ⬆️
...roid/sessionreplay/internal/utils/DrawableUtils.kt 93.94% <80.00%> (-1.37%) ⬇️

... and 25 files with indirect coverage changes

@jonathanmos jonathanmos marked this pull request as ready for review March 4, 2024 09:29
@jonathanmos jonathanmos requested review from a team as code owners March 4, 2024 09:29
Copy link
Member

@mariusc83 mariusc83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job !! Can you please also mark the issue as closed once you merge this ?

@jonathanmos jonathanmos force-pushed the jmoskovich/rum-3276/fix-resized-drawables branch from 26de2cb to b8802bd Compare March 5, 2024 13:13
@jonathanmos jonathanmos merged commit 0e3a8b0 into develop Mar 5, 2024
23 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/rum-3276/fix-resized-drawables branch March 5, 2024 15:29
@xgouchet xgouchet added this to the 2.7.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants