-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(1/10) RUM-2895 create SR Compose module #1879
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! left some comments
features/dd-sdk-android-session-replay-compose/build.gradle.kts
Outdated
Show resolved
Hide resolved
javadocConfig() | ||
dependencyUpdateConfig() | ||
publishingConfig( | ||
"Session Replay Extension Support for Material UI components." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Session Replay Extension Support for Material UI components." | |
"Session Replay Extension Support for Jetpack Compose." |
|
||
|
||
## ComposeView & AndroidComposeView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## ComposeView & AndroidComposeView | |
## ComposeView & AndroidComposeView |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once other comments are addressed.
The base branch was changed.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## feature/sr_compose #1879 +/- ##
======================================================
- Coverage 83.40% 83.31% -0.10%
======================================================
Files 479 479
Lines 16935 16934 -1
Branches 2527 2527
======================================================
- Hits 14124 14107 -17
- Misses 2128 2135 +7
- Partials 683 692 +9 |
This PR has been created automatically by splitting a large branch
RUM-2895 create SR Compose module