Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(1/10) RUM-2895 create SR Compose module #1879

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

xgouchet
Copy link
Member

This PR has been created automatically by splitting a large branch

RUM-2895 create SR Compose module

@xgouchet xgouchet requested review from a team as code owners February 23, 2024 15:57
0xnm
0xnm previously approved these changes Feb 23, 2024
Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! left some comments

features/dd-sdk-android-session-replay-compose/README.md Outdated Show resolved Hide resolved
javadocConfig()
dependencyUpdateConfig()
publishingConfig(
"Session Replay Extension Support for Material UI components."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Session Replay Extension Support for Material UI components."
"Session Replay Extension Support for Jetpack Compose."

Comment on lines 1 to 3


## ComposeView & AndroidComposeView
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## ComposeView & AndroidComposeView
## ComposeView & AndroidComposeView

hestonhoffman
hestonhoffman previously approved these changes Feb 23, 2024
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once other comments are addressed.

mariusc83
mariusc83 previously approved these changes Feb 26, 2024
@xgouchet xgouchet changed the base branch from develop to feature/sr_compose February 26, 2024 10:04
@xgouchet xgouchet dismissed stale reviews from mariusc83, hestonhoffman, and 0xnm February 26, 2024 10:04

The base branch was changed.

@xgouchet xgouchet requested a review from 0xnm February 28, 2024 16:06
@codecov-commenter
Copy link

Codecov Report

Merging #1879 (db521c8) into feature/sr_compose (6d24e01) will decrease coverage by 0.10%.
The diff coverage is n/a.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/sr_compose    #1879      +/-   ##
======================================================
- Coverage               83.40%   83.31%   -0.10%     
======================================================
  Files                     479      479              
  Lines                   16935    16934       -1     
  Branches                 2527     2527              
======================================================
- Hits                    14124    14107      -17     
- Misses                   2128     2135       +7     
- Partials                  683      692       +9     

see 23 files with indirect coverage changes

@xgouchet xgouchet requested a review from mariusc83 February 29, 2024 08:48
@xgouchet xgouchet merged commit bc1739b into feature/sr_compose Mar 4, 2024
23 checks passed
@xgouchet xgouchet deleted the xgouchet/1_sr_compose branch March 4, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants