Use shared dependencies license plugin #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
reviewed
Jan 26, 2024
| @@ -1,7 +1,7 @@ | |||
| [versions] | |||
| # Commons | |||
| kotlin = "1.8.10" | |||
| kotlinSP = "1.8.10-1.0.9" | |||
| kotlin = "1.9.10" | |||
There was a problem hiding this comment.
why do we need this change?
Moreover, we cannot use Kotlin 1.8.20 and above because of the following issue https://youtrack.jetbrains.com/issue/KT-60748 - we either need to apply workaround provided, or rename tests.
xgouchet
force-pushed
the
xgouchet/dependencies_license_plugin
branch
from
582a2aa to
c8cf41b
Compare
xgouchet
force-pushed
the
xgouchet/dependencies_license_plugin
branch
from
c8cf41b to
9f1ee4a
Compare
xgouchet
force-pushed
the
xgouchet/dependencies_license_plugin
branch
from
9f1ee4a to
e5b817b
Compare
xgouchet
force-pushed
the
xgouchet/dependencies_license_plugin
branch
from
e5b817b to
19d16ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1843 +/- ##
===========================================
- Coverage 70.00% 69.93% -0.07%
===========================================
Files 726 726
Lines 26967 26988 +21
Branches 4516 4523 +7
===========================================
- Hits 18876 18873 -3
- Misses 6819 6837 +18
- Partials 1272 1278 +6 |
|
I have same doubt as Nikita, otherwise LTGM! |
|
ambushwork
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use the shared dependency license plugin replacing the one embedded in
buildSrc