-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-1702: Start session when RUM is initialized #1832
RUM-1702: Start session when RUM is initialized #1832
Conversation
2c389f1
to
797d76a
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1832 +/- ##
===========================================
- Coverage 83.49% 83.45% -0.05%
===========================================
Files 467 467
Lines 16491 16476 -15
Branches 2483 2482 -1
===========================================
- Hits 13769 13749 -20
- Misses 2043 2045 +2
- Partials 679 682 +3
|
797d76a
to
198cbb6
Compare
198cbb6
to
14025c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Agree we should have @ncreated take a look and make sure the logic is the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks okay 👍. Good idea to map the new "sdk init" command into existing "app start" to minimise the change impact 👌.
What does this PR do?
This change starts RUM session during the
Rum.enable
call. The general rule is like that:foreground
type, then session will be started (with interaction time set at the moment of initialization), andApplicationLaunch
view withapplication_started
event will be created.foreground
as type, session will be initialized only if background tracking is enabled, noApplicationLaunch
view will be created.This PR is using the notion of
SdkInit
class, even though it is possible to use onlyApplicationStarted
event in order to be on-par with the similar logic in iOS SDK. Also it is still using event system for the session initialization in order to minimize the footprint of the change (it will be easier to rollback it if needed).Review checklist (to be filled by reviewers)