Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RUM Schema #1828

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Update RUM Schema #1828

merged 1 commit into from
Jan 17, 2024

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jan 17, 2024

What does this PR do?

This PR does the update of the RUM schema to the latest version (Note: build_id change is removed).

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners January 17, 2024 10:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2024

Codecov Report

Merging #1828 (c29effe) into develop (8c57aad) will increase coverage by 0.08%.
The diff coverage is 93.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1828      +/-   ##
===========================================
+ Coverage    83.50%   83.58%   +0.08%     
===========================================
  Files          467      467              
  Lines        16483    16474       -9     
  Branches      2482     2483       +1     
===========================================
+ Hits         13764    13769       +5     
+ Misses        2036     2029       -7     
+ Partials       683      676       -7     
Files Coverage Δ
...ndroid/rum/internal/domain/scope/RumActionScope.kt 96.61% <100.00%> (ø)
...g/android/rum/internal/domain/scope/RumEventExt.kt 93.47% <100.00%> (+0.34%) ⬆️
...roid/rum/internal/domain/scope/RumResourceScope.kt 94.80% <100.00%> (+0.37%) ⬆️
.../android/rum/internal/domain/scope/RumViewScope.kt 93.31% <100.00%> (-0.61%) ⬇️
...id/rum/internal/ndk/DatadogNdkCrashEventHandler.kt 84.91% <66.67%> (+3.77%) ⬆️

... and 19 files with indirect coverage changes

@0xnm 0xnm merged commit 3d5e3d6 into develop Jan 17, 2024
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/update-rum-schema-170123 branch January 17, 2024 14:05
@xgouchet xgouchet added this to the 2.6.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants