Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1520 prevent false positive warning #1815

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

xgouchet
Copy link
Member

@xgouchet xgouchet commented Jan 9, 2024

What does this PR do?

Prevent a false positive warning in the logcat when the logs feature is available but no fields is provided to the span.log() method

@xgouchet xgouchet requested review from a team as code owners January 9, 2024 09:57
@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Merging #1815 (a32ff40) into develop (88069eb) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1815      +/-   ##
===========================================
- Coverage    83.52%   83.45%   -0.07%     
===========================================
  Files          466      466              
  Lines        16368    16364       -4     
  Branches      2455     2452       -3     
===========================================
- Hits         13670    13656      -14     
- Misses        2028     2036       +8     
- Partials       670      672       +2     
Files Coverage Δ
.../trace/internal/handlers/AndroidSpanLogsHandler.kt 87.76% <0.00%> (-1.83%) ⬇️

... and 19 files with indirect coverage changes

@xgouchet xgouchet merged commit a2757af into develop Jan 9, 2024
23 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-1520/remove_warning branch January 9, 2024 14:08
@xgouchet xgouchet added this to the 2.5.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants