Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-2441 make synthetics logs more verbose #1813

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

xgouchet
Copy link
Member

@xgouchet xgouchet commented Jan 8, 2024

What does this PR do?

Prints the application and session id whenever a view changes.

Motivation

The Synthetics team have a delay when fetching logs from the device running the app under test. Because of this the initial Application and Session ID (printed early in the app's lifecycle) are lost and can't be retrieved. Repeating them whenever a view is started provides a workaround if the first logs of the app can't be read.

@xgouchet xgouchet requested review from a team as code owners January 8, 2024 12:52
@xgouchet xgouchet force-pushed the xgouchet/RUM-2441/verbose_synthetics_logs branch from f0360f9 to 48344ed Compare January 8, 2024 14:05
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

Merging #1813 (48344ed) into develop (a21c278) will decrease coverage by 0.02%.
Report is 6 commits behind head on develop.
The diff coverage is 62.50%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1813      +/-   ##
===========================================
- Coverage    83.44%   83.42%   -0.02%     
===========================================
  Files          466      466              
  Lines        16375    16378       +3     
  Branches      2455     2454       -1     
===========================================
  Hits         13663    13663              
+ Misses        2047     2042       -5     
- Partials       665      673       +8     
Files Coverage Δ
...d/rum/internal/domain/scope/RumApplicationScope.kt 89.90% <ø> (+0.90%) ⬆️
...droid/rum/internal/domain/scope/RumSessionScope.kt 96.23% <ø> (-0.07%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 93.06% <62.50%> (-0.70%) ⬇️

... and 20 files with indirect coverage changes

@xgouchet xgouchet merged commit 0f3e356 into develop Jan 10, 2024
23 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-2441/verbose_synthetics_logs branch January 10, 2024 08:38
@xgouchet xgouchet added this to the 2.5.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants