Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-517: Migrate Realm from KAPT to KSP #1794

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Dec 28, 2023

What does this PR do?

This PR migrates Realm from KAPT to KSP usage. The only remaining piece which is using KAPT is Glide, but there is a blocker bumptech/glide#5328.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested review from a team as code owners December 28, 2023 09:45
@0xnm 0xnm force-pushed the nogorodnikov/rum-517/migrate-realm-from-kapt-to-ksp branch from 5061ac5 to 4be017f Compare December 28, 2023 09:48
@0xnm 0xnm force-pushed the nogorodnikov/rum-517/migrate-realm-from-kapt-to-ksp branch from 4be017f to 7f40869 Compare December 28, 2023 09:48
@codecov-commenter
Copy link

Codecov Report

Merging #1794 (7f40869) into develop (c632c79) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1794      +/-   ##
===========================================
- Coverage    83.44%   83.43%   -0.01%     
===========================================
  Files          466      466              
  Lines        16367    16372       +5     
  Branches      2453     2454       +1     
===========================================
+ Hits         13656    13659       +3     
  Misses        2042     2042              
- Partials       669      671       +2     

see 25 files with indirect coverage changes

@0xnm 0xnm merged commit 9ac1e2a into develop Dec 28, 2023
23 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-517/migrate-realm-from-kapt-to-ksp branch December 28, 2023 15:59
@xgouchet xgouchet added this to the 2.5.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants