Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-2075 remove data store/upload config from feature configuration #1778

Merged

Conversation

mariusc83
Copy link
Member

What does this PR do?

Because we needed to add a workaround for SR data storage and upload configuration we added the batchProcessingLevel, batchSize and uploadFrequency at the FeatureStorageConfiguration level. Based on the latest improvements we added at the Uploader and the latest telemetry we concluded that this workaround is not needed anymore and we can remove this noise from our code base.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Dec 20, 2023
@mariusc83 mariusc83 marked this pull request as ready for review December 20, 2023 10:32
@mariusc83 mariusc83 requested review from a team as code owners December 20, 2023 10:32
@codecov-commenter
Copy link

Codecov Report

Merging #1778 (102e46c) into develop (c048dcd) will increase coverage by 0.03%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1778      +/-   ##
===========================================
+ Coverage    83.36%   83.38%   +0.03%     
===========================================
  Files          465      465              
  Lines        16348    16331      -17     
  Branches      2456     2451       -5     
===========================================
- Hits         13627    13617      -10     
+ Misses        2047     2041       -6     
+ Partials       674      673       -1     
Files Coverage Δ
...android/api/storage/FeatureStorageConfiguration.kt 100.00% <100.00%> (ø)
...in/com/datadog/android/core/internal/SdkFeature.kt 91.55% <100.00%> (+2.15%) ⬆️
...oid/sessionreplay/internal/SessionReplayFeature.kt 99.00% <100.00%> (-0.02%) ⬇️

... and 25 files with indirect coverage changes

@mariusc83 mariusc83 merged commit b2dc437 into develop Dec 20, 2023
23 checks passed
@mariusc83 mariusc83 deleted the mconstantin/rum-2075/remove-data-upload-config-from-feature branch December 20, 2023 11:55
@xgouchet xgouchet added this to the 2.4.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants