Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1520 Remove obsolete integration tests #1770

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

xgouchet
Copy link
Member

What does this PR do?

Remove obsolete tests in the Instrumented/integration module.
Those tests are now covered in the reliability/single-fit/logs module.

@xgouchet xgouchet requested review from a team as code owners December 15, 2023 15:24
@xgouchet xgouchet force-pushed the xgouchet/RUM-1520/single-fit-logs branch from 105c9ec to 8da8d33 Compare December 15, 2023 15:31
@xgouchet xgouchet force-pushed the xgouchet/RUM-1520/update_obsolete_logs_tests branch 2 times, most recently from f01860a to 77f8738 Compare December 15, 2023 15:47
@xgouchet xgouchet force-pushed the xgouchet/RUM-1520/single-fit-logs branch from 8da8d33 to e33ff12 Compare December 15, 2023 17:04
@xgouchet xgouchet force-pushed the xgouchet/RUM-1520/update_obsolete_logs_tests branch from 77f8738 to b679636 Compare December 15, 2023 17:22
@codecov-commenter
Copy link

Codecov Report

Merging #1770 (b679636) into xgouchet/RUM-1520/single-fit-logs (e33ff12) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files
@@                          Coverage Diff                          @@
##           xgouchet/RUM-1520/single-fit-logs    #1770      +/-   ##
=====================================================================
+ Coverage                              83.44%   83.47%   +0.02%     
=====================================================================
  Files                                    469      469              
  Lines                                  16408    16408              
  Branches                                2449     2449              
=====================================================================
+ Hits                                   13691    13695       +4     
  Misses                                  2046     2046              
+ Partials                                 671      667       -4     

see 23 files with indirect coverage changes

Base automatically changed from xgouchet/RUM-1520/single-fit-logs to develop December 18, 2023 10:59
@xgouchet xgouchet merged commit e609161 into develop Dec 18, 2023
22 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-1520/update_obsolete_logs_tests branch December 18, 2023 11:28
@xgouchet xgouchet added this to the 2.4.0 milestone Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants