-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RUM-2014 Add the synchronous equivalent of readNextBatch and confirmBatchRead in Storage API #1768
RUM-2014 Add the synchronous equivalent of readNextBatch and confirmBatchRead in Storage API #1768
Conversation
7d8e3a0
to
6aa4e11
Compare
8c4946f
to
22c0a1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning
We still have asynchronous confirmBatchRead
in the DataUploader, so we might want to also have a synchronous method there WDYT?
22c0a1c
to
1183b5e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1768 +/- ##
===========================================
+ Coverage 83.42% 83.55% +0.12%
===========================================
Files 469 469
Lines 16434 16431 -3
Branches 2454 2465 +11
===========================================
+ Hits 13710 13728 +18
+ Misses 2053 2030 -23
- Partials 671 673 +2
|
418a509
to
ce6cd6e
Compare
ce6cd6e
to
28258ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! need also to delete duplicate DataUploader
, DataFlusher
, etc. files.
fcd74a9
to
6e89ab6
Compare
6e89ab6
to
c699fc4
Compare
In this PR we are replacing the async methods
readNextBatch
andconfirmBatchRead
fromStorage
interface with their synchronous equivalents.What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)