RUM-2568: Better handling of event write errors in RUM #1766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR improves any error handling in the write pipeline of RUM. Before, if there was any exception thrown inside writing pipeline which wasn't caught, or if write wasn't successful, we didn't notify that event wasn't written (or dropped, in other words). This prevented to decrease
pendingXXX
counters inRumViewScope
, thus makingisComplete
to evaluate tofalse
in such cases.This PR also centralizes the place where the notification about write success or failure is sent.
Review checklist (to be filled by reviewers)