RUM-2441 Print RUM app, session and view ID in LogCat #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
approved these changes
Dec 12, 2023
xgouchet
force-pushed
the
xgouchet/RUM-2441/log_rum_info_for_synthetics
branch
from
e9a2bcf to
9b4acbe
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #1760 +/- ##
===========================================
+ Coverage 83.52% 83.56% +0.04%
===========================================
Files 468 469 +1
Lines 16386 16391 +5
Branches 2445 2447 +2
===========================================
+ Hits 13685 13696 +11
+ Misses 2037 2031 -6
Partials 664 664
|
mariusc83
reviewed
Dec 12, 2023
| @@ -77,6 +78,7 @@ internal class RumApplicationScope( | |||
| syntheticsTestId = event.testId, | |||
| syntheticsResultId = event.resultId | |||
| ) | |||
| Log.i(RumScope.SYNTHETICS_LOGCAT_TAG, "_dd.application.id=${rumContext.applicationId}") | |||
There was a problem hiding this comment.
Is this safe to expose it in the Logcat ? The session Id and view Id is something we generated but the applicationId is the actual RUM application ID.
There was a problem hiding this comment.
It's only exposed when being ran via Synthetics.
Also the RUM Application ID is an identifier, not a token or a key. Just having the App id gives no permission by itself
jonathanmos
approved these changes
Dec 13, 2023
mariusc83
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Print the RUM app, session and view ID in LogCat
Motivation
Let the Synthetics runner know what those ids are to create a link from a test run to the linked RUM events