Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3/4) RUM-2129 Implement AbstractStorage #1747

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

xgouchet
Copy link
Member

@xgouchet xgouchet commented Nov 27, 2023

This PR has been created automatically by splitting a large branch

Pull request 3 out of 4

The overall goal is to create a feature allowing customers to store unsent data any way they want (instead of using the official disk batch files)

This PR implements our Internal Storage interface based on a PersistenceStrategy, in a Consent Aware manner. This means that the tracking of consent is handled internally, and our customers don't need to worry about that part.

@xgouchet xgouchet requested review from a team as code owners November 27, 2023 09:01
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2023

Codecov Report

Merging #1747 (729ec6a) into xgouchet/RUM-2129/2_custom_persistence_mgt (c2a203b) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files
@@                              Coverage Diff                               @@
##           xgouchet/RUM-2129/2_custom_persistence_mgt    #1747      +/-   ##
==============================================================================
+ Coverage                                       83.29%   83.35%   +0.06%     
==============================================================================
  Files                                             466      467       +1     
  Lines                                           16189    16239      +50     
  Branches                                         2412     2417       +5     
==============================================================================
+ Hits                                            13484    13536      +52     
- Misses                                           2043     2044       +1     
+ Partials                                          662      659       -3     
Files Coverage Δ
...droid/core/internal/persistence/AbstractStorage.kt 100.00% <100.00%> (ø)
...d/core/internal/persistence/ConsentAwareStorage.kt 98.78% <100.00%> (ø)
...tadog/android/core/internal/persistence/Storage.kt 100.00% <ø> (ø)

... and 29 files with indirect coverage changes

Base automatically changed from xgouchet/RUM-2129/2_custom_persistence_mgt to develop November 29, 2023 10:25
@xgouchet xgouchet merged commit be90fc0 into develop Nov 29, 2023
22 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-2129/3_custom_persistence_mgt branch November 29, 2023 11:21
@xgouchet xgouchet added this to the 2.4.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants