Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1517 create Stub Core module #1740

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

xgouchet
Copy link
Member

What does this PR do?

Because AndroidStudio doesn't deal well with testFixtures source sets, the Stubbed SDKCore (and linked classes) were moved to an independent module which allows code completion and make the IDE happy.

@xgouchet xgouchet requested review from a team as code owners November 22, 2023 07:55
reliability/stub-core/build.gradle.kts Outdated Show resolved Hide resolved
@xgouchet xgouchet force-pushed the xgouchet/RUM-1517/stub_core_module branch from 42bc7c5 to a0a47d7 Compare November 22, 2023 08:30
@xgouchet xgouchet requested a review from 0xnm November 22, 2023 08:30
@xgouchet xgouchet force-pushed the xgouchet/RUM-1517/stub_core_module branch from a0a47d7 to 46d11d7 Compare November 22, 2023 11:12
@codecov-commenter
Copy link

Codecov Report

Merging #1740 (46d11d7) into develop (7845f86) will decrease coverage by 0.00%.
Report is 6 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1740      +/-   ##
===========================================
- Coverage    83.36%   83.35%   -0.00%     
===========================================
  Files          465      465              
  Lines        16182    16179       -3     
  Branches      2412     2411       -1     
===========================================
- Hits         13489    13486       -3     
+ Misses        2033     2027       -6     
- Partials       660      666       +6     

see 21 files with indirect coverage changes

@xgouchet xgouchet merged commit 1805cfb into develop Nov 23, 2023
5 checks passed
@xgouchet xgouchet deleted the xgouchet/RUM-1517/stub_core_module branch November 23, 2023 10:31
@xgouchet xgouchet added this to the 2.4.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants