Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1556: Update default propagation style from Datadog to Datadog+TraceContext #1696

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Nov 13, 2023

What does this PR do?

This is Android counterpart of DataDog/dd-sdk-ios#1529

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner November 13, 2023 15:38
@0xnm 0xnm force-pushed the nogorodnikov/rum-1556/update-default-propagation-style-from-datadog-to-datadog-and-tracecontext branch from b59f8ec to 46f06cb Compare November 13, 2023 15:41
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2023

Codecov Report

Merging #1696 (46f06cb) into develop (43c2c3e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1696      +/-   ##
===========================================
- Coverage    83.53%   83.52%   -0.01%     
===========================================
  Files          465      465              
  Lines        16025    16030       +5     
  Branches      2376     2375       -1     
===========================================
+ Hits         13385    13388       +3     
- Misses        1999     2003       +4     
+ Partials       641      639       -2     
Files Coverage Δ
...atadog/android/core/configuration/Configuration.kt 96.51% <100.00%> (+0.13%) ⬆️
...nal/net/DefaultFirstPartyHostHeaderTypeResolver.kt 90.48% <100.00%> (+1.00%) ⬆️
.../kotlin/com/datadog/android/trace/AndroidTracer.kt 96.30% <100.00%> (+1.06%) ⬆️
...n/com/datadog/android/okhttp/DatadogInterceptor.kt 72.54% <100.00%> (+0.59%) ⬆️
...datadog/android/okhttp/trace/TracingInterceptor.kt 81.67% <100.00%> (+1.03%) ⬆️

... and 21 files with indirect coverage changes

@0xnm 0xnm merged commit c882814 into develop Nov 14, 2023
5 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-1556/update-default-propagation-style-from-datadog-to-datadog-and-tracecontext branch November 14, 2023 11:05
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants