Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include rum-mobile-android as codeowner #1695

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

plousada
Copy link
Member

What does this PR do?

This PR includes the rum-mobile-android team as a code owning team in order to ensure we have at least 1 Android Engineer reviewing every merged PR.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@plousada plousada requested a review from a team as a code owner November 13, 2023 11:36
@codecov-commenter
Copy link

Codecov Report

Merging #1695 (13d59f2) into develop (7e80c37) will decrease coverage by 0.04%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1695      +/-   ##
===========================================
- Coverage    83.73%   83.69%   -0.04%     
===========================================
  Files          463      463              
  Lines        15896    15893       -3     
  Branches      2371     2370       -1     
===========================================
- Hits         13310    13301       -9     
  Misses        1951     1951              
- Partials       635      641       +6     

see 18 files with indirect coverage changes

@plousada plousada merged commit 9a80cf9 into develop Nov 13, 2023
5 checks passed
@plousada plousada deleted the plousada/include_rum_mobile_android_codeowner branch November 13, 2023 16:33
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants