Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1924: Use tracestate header to supply vendor-specific information #1694

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Nov 13, 2023

What does this PR do?

This PR adds tracestate header with Datadog-specific information in case of TRACECONTEXT tracing. This header will contain the following Datadog-specific tags:

  • p - parent ID
  • s - sampling decision
  • o - origin, if exists. In case of instrumentation with RUM, it will have rum value.

Full spec https://www.w3.org/TR/trace-context/#tracestate-header

iOS counterpart DataDog/dd-sdk-ios#1536

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner November 13, 2023 10:06
@0xnm 0xnm force-pushed the nogorodnikov/rum-1924/use-tracestate-to-supply-vendor-specific-information branch from 0d92e7a to c4a7806 Compare November 13, 2023 10:18
@codecov-commenter
Copy link

Codecov Report

Merging #1694 (c4a7806) into develop (7e80c37) will decrease coverage by 0.14%.
The diff coverage is 22.92%.

@@             Coverage Diff             @@
##           develop    #1694      +/-   ##
===========================================
- Coverage    83.73%   83.59%   -0.14%     
===========================================
  Files          463      463              
  Lines        15896    15934      +38     
  Branches      2371     2377       +6     
===========================================
+ Hits         13310    13319       +9     
- Misses        1951     1978      +27     
- Partials       635      637       +2     
Files Coverage Δ
...datadog/android/okhttp/trace/TracingInterceptor.kt 82.03% <91.67%> (+1.39%) ⬆️
.../datadog/opentracing/propagation/W3CHttpCodec.java 3.30% <0.00%> (-1.88%) ⬇️

... and 16 files with indirect coverage changes

@0xnm 0xnm merged commit 8196669 into develop Nov 14, 2023
5 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-1924/use-tracestate-to-supply-vendor-specific-information branch November 14, 2023 15:18
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants