Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-2104: Fix the issue of missing cpu/memory info with RUM view events #1693

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Nov 9, 2023

What does this PR do?

RUM data was missing cpu/memory info since SDK v2, because we were safe-casting the property of RUM context to the wrong type.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner November 9, 2023 17:16
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Merging #1693 (022c8f7) into develop (b6112d9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1693      +/-   ##
===========================================
- Coverage    83.70%   83.69%   -0.01%     
===========================================
  Files          463      463              
  Lines        15889    15887       -2     
  Branches      2371     2369       -2     
===========================================
- Hits         13299    13296       -3     
- Misses        1947     1959      +12     
+ Partials       643      632      -11     
Files Coverage Δ
...android/rum/internal/vitals/VitalReaderRunnable.kt 100.00% <100.00%> (ø)

... and 21 files with indirect coverage changes

@0xnm 0xnm merged commit 8671830 into develop Nov 10, 2023
5 checks passed
@0xnm 0xnm deleted the nogorodnikov/rum-2104/memory-and-cpu-info-is-not-sent branch November 10, 2023 07:42
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants