Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUM-1985 Add the batchProcessingLevel value to the Configuration Telemetry #1691

Conversation

mariusc83
Copy link
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Nov 9, 2023
@mariusc83 mariusc83 changed the base branch from develop to mconstantin/rum-1983/introduce-the-batch-processing-level-api November 9, 2023 08:10
@mariusc83 mariusc83 force-pushed the mconstantin/rum-1985/add-batch-processing-level-into-telemetry branch from 2c4aa48 to b9c1cb7 Compare November 9, 2023 08:24
@mariusc83 mariusc83 marked this pull request as ready for review November 9, 2023 08:25
@mariusc83 mariusc83 requested a review from a team as a code owner November 9, 2023 08:25
0xnm
0xnm previously approved these changes Nov 9, 2023
jonathanmos
jonathanmos previously approved these changes Nov 9, 2023
@mariusc83 mariusc83 force-pushed the mconstantin/rum-1985/add-batch-processing-level-into-telemetry branch from b9c1cb7 to 6c881f4 Compare November 9, 2023 11:07
@mariusc83 mariusc83 force-pushed the mconstantin/rum-1983/introduce-the-batch-processing-level-api branch from 26eead2 to 523d10a Compare November 9, 2023 11:16
@mariusc83 mariusc83 force-pushed the mconstantin/rum-1985/add-batch-processing-level-into-telemetry branch from 6c881f4 to 02c5c73 Compare November 9, 2023 11:51
@mariusc83 mariusc83 force-pushed the mconstantin/rum-1983/introduce-the-batch-processing-level-api branch 2 times, most recently from 612a23f to 7dbfa0a Compare November 9, 2023 11:54
Base automatically changed from mconstantin/rum-1983/introduce-the-batch-processing-level-api to develop November 9, 2023 14:04
@mariusc83 mariusc83 dismissed stale reviews from jonathanmos and 0xnm November 9, 2023 14:04

The base branch was changed.

@mariusc83 mariusc83 force-pushed the mconstantin/rum-1985/add-batch-processing-level-into-telemetry branch from 02c5c73 to b99ec22 Compare November 9, 2023 16:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Merging #1691 (262f1ef) into develop (8671830) will increase coverage by 0.11%.
The diff coverage is 81.82%.

@@             Coverage Diff             @@
##           develop    #1691      +/-   ##
===========================================
+ Coverage    83.69%   83.80%   +0.11%     
===========================================
  Files          463      463              
  Lines        15890    15896       +6     
  Branches      2370     2371       +1     
===========================================
+ Hits         13298    13321      +23     
+ Misses        1948     1944       -4     
+ Partials       644      631      -13     
Files Coverage Δ
...ndroid/telemetry/internal/TelemetryEventHandler.kt 80.72% <100.00%> (+2.54%) ⬆️
...ain/kotlin/com/datadog/android/core/DatadogCore.kt 84.24% <66.67%> (+0.17%) ⬆️
...d/telemetry/internal/TelemetryCoreConfiguration.kt 88.89% <83.33%> (+1.39%) ⬆️

... and 20 files with indirect coverage changes

@mariusc83 mariusc83 force-pushed the mconstantin/rum-1985/add-batch-processing-level-into-telemetry branch from b99ec22 to 262f1ef Compare November 10, 2023 08:18
@mariusc83 mariusc83 merged commit 7e80c37 into develop Nov 10, 2023
5 checks passed
@mariusc83 mariusc83 deleted the mconstantin/rum-1985/add-batch-processing-level-into-telemetry branch November 10, 2023 08:42
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants