RUM-1493 add ci task to update E2E sample app #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1688 +/- ##
===========================================
- Coverage 83.73% 83.65% -0.08%
===========================================
Files 462 462
Lines 15855 15855
Branches 2365 2365
===========================================
- Hits 13275 13262 -13
- Misses 1939 1955 +16
+ Partials 641 638 -3 |
0xnm
approved these changes
Nov 3, 2023
sample/kotlin/build.gradle.kts
Outdated
| storeFile = File(project.rootDir, "sample-android.keystore") | ||
| storePassword = System.getenv("E2E_STORE_PASSWD") | ||
| keyAlias = "dd-sdk-android" | ||
| keyPassword = System.getenv("E2E_STORE_PASSWD") |
There was a problem hiding this comment.
just checking that it is not a typo: key password is the same as store password?
There was a problem hiding this comment.
Yes, unfortunately android signing requires the same password for both :/
mariusc83
approved these changes
Nov 3, 2023
xgouchet
force-pushed
the
xgouchet/RUM-1493/upload_sample_app_synthetics
branch
6 times, most recently
from
a0817bf to
30b6874
Compare
jonathanmos
approved these changes
Nov 6, 2023
xgouchet
force-pushed
the
xgouchet/RUM-1493/upload_sample_app_synthetics
branch
12 times, most recently
from
5e167b7 to
d886ed1
Compare
0xnm
approved these changes
Nov 7, 2023
| - export E2E_DD_API_KEY=$(aws ssm get-parameter --region us-east-1 --name ci.dd-sdk-android.e2e_api_key --with-decryption --query "Parameter.Value" --out text) | ||
| - export E2E_DD_APP_KEY=$(aws ssm get-parameter --region us-east-1 --name ci.dd-sdk-android.e2e_app_key --with-decryption --query "Parameter.Value" --out text) | ||
| - export E2E_MOBILE_APP_ID=$(aws ssm get-parameter --region us-east-1 --name ci.dd-sdk-android.e2e_mobile_app_id --with-decryption --query "Parameter.Value" --out text) | ||
| - GRADLE_OPTS="-Xmx4096M" ./gradlew assembleLibraries --stacktrace --no-daemon |
There was a problem hiding this comment.
should we remove GRADLE_OPTS with Xmx everywhere in this file, given that we have it declared in gradle.properties?
xgouchet
force-pushed
the
xgouchet/RUM-1493/upload_sample_app_synthetics
branch
from
d886ed1 to
23aaccf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This task builds and uploads the sample app to our synthetics org and marks it as latest