RUM-321: Introduce view event filtering in upload pipeline, remove view event throttling in write pipeline #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
requested changes
Oct 19, 2023
...dk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/event/RumEventMeta.kt
Outdated
Show resolved
Hide resolved
...um/src/main/kotlin/com/datadog/android/rum/internal/domain/event/RumEventMetaDeserializer.kt
Outdated
Show resolved
Hide resolved
Comment on lines
35
to
38
| NullPointerException::class, | ||
| ClassCastException::class, | ||
| IllegalStateException::class, | ||
| NumberFormatException::class |
There was a problem hiding this comment.
Note
It might be relevant to add as a comment what situation those exception could rise from?
There was a problem hiding this comment.
I changed the way we are doing the parsing, so that it looks now the same as for other RUM events and the only exception thrown is JsonParseException. Let me know what you think.
...dk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/event/RumEventMeta.kt
Outdated
Show resolved
Hide resolved
...dk-android-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/event/RumEventMeta.kt
Outdated
Show resolved
Hide resolved
...-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/event/RumEventMetaSerializer.kt
Outdated
Show resolved
Hide resolved
mariusc83
previously approved these changes
Oct 23, 2023
...roid-rum/src/main/kotlin/com/datadog/android/rum/internal/domain/event/RumViewEventFilter.kt
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## develop #1678 +/- ##
===========================================
+ Coverage 83.70% 83.71% +0.01%
===========================================
Files 459 462 +3
Lines 15770 15843 +73
Branches 2360 2363 +3
===========================================
+ Hits 13200 13262 +62
+ Misses 1945 1943 -2
- Partials 625 638 +13
|
0xnm
force-pushed
the
nogorodnikov/rum-321/reduce-view-events-in-upload-pipeline
branch
from
de31563 to
4a3f24c
Compare
xgouchet
approved these changes
Oct 26, 2023
0xnm
deleted the
nogorodnikov/rum-321/reduce-view-events-in-upload-pipeline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is the counterpart of DataDog/dd-sdk-ios#1328 for Android.
This PR filters out RUM View events during the upload process following the logic that batch should have only one RUM view event for a given ID and this event should have maximum
documentVersionproperty value. To support that we introduce RUM View event metadata which will be attached to every view event written and read back during the upload cycle.View throttling logic in
RumViewScopeis removed.Review checklist (to be filled by reviewers)