RUM-1578: Support returning event metadata to the readers #1670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a pre-requisite for the change where we are going to reduce RUM views on the client side.
This PR looks big, but what is does essentially is just shifting the responsibility of the event metadata generation to the feature side (change the signature of
writeData
to accept newly created classRawBatchEvent(data, meta)
), and also makesreadData
to return this pair of event data +metadata, so that they can be later processed in the upload pipeline.Signature change of the upload pipeline is similar to what was done in https://github.com/DataDog/dd-sdk-ios/pull/1328/files#diff-a6e4927f6142a31326e45af76631e0538c32b90f419b8856e5d4bad1ecfa99c0.
The structure of
RawBatchEvent
is similar to https://github.com/DataDog/dd-sdk-ios/pull/1328/files#diff-6e6d2fa1d307e2172f3a6a08142a5f78106dbe374927ba3da5926deb33decbacReview checklist (to be filled by reviewers)