(2/3) RUM-392 refactor shared android library build script #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
force-pushed
the
xgouchet/RUM-392/1_shared_core_fixtures
branch
2 times, most recently
from
d94a25d to
eea183c
Compare
0xnm
reviewed
Oct 12, 2023
There was a problem hiding this comment.
In the future probably it will be better to switch from buildSrc to the composite build usage (like mobile app is doing). I tried to do a quick migration, but then the problem is that some extension symbols are not available and the only way to make things work is to re-write everything to plugins, which is quite a work.
There was a problem hiding this comment.
That might be an idea, we need to see the pros and cons of that. A quick read on the composite build docs left a lot of questions, so I think this might be better addressed as an exploration/ADR.
buildSrc/src/main/kotlin/com/datadog/gradle/config/AndroidConfig.kt
Outdated
Show resolved
Hide resolved
mariusc83
reviewed
Oct 12, 2023
integrations/dd-sdk-android-sqldelight/api/dd-sdk-android-sqldelight.api
Outdated
Show resolved
Hide resolved
xgouchet
force-pushed
the
xgouchet/RUM-392/2_shared_core_fixtures
branch
2 times, most recently
from
d006017 to
172b18f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1667 +/- ##
===========================================
- Coverage 83.73% 83.71% -0.02%
===========================================
Files 459 459
Lines 15778 15778
Branches 2354 2354
===========================================
- Hits 13211 13208 -3
- Misses 1938 1943 +5
+ Partials 629 627 -2 |
mariusc83
previously approved these changes
Oct 12, 2023
0xnm
previously approved these changes
Oct 12, 2023
Base automatically changed from
xgouchet/RUM-392/1_shared_core_fixtures
to
develop
October 16, 2023 08:42
xgouchet
dismissed stale reviews from 0xnm and mariusc83
The base branch was changed.
xgouchet
force-pushed
the
xgouchet/RUM-392/2_shared_core_fixtures
branch
from
172b18f to
2c2668e
Compare
0xnm
requested changes
Oct 16, 2023
xgouchet
force-pushed
the
xgouchet/RUM-392/2_shared_core_fixtures
branch
from
2c2668e to
3de4864
Compare
0xnm
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR refactor the
build.gradle.ktsbuildscript for all our libraries to extract shared configurations and make it easier to:Motivation
This is part of our effort on improving our test suites across the mobile teams