Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable warning as errors locally #1664

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

xgouchet
Copy link
Member

@xgouchet xgouchet commented Oct 9, 2023

What does this PR do?

Use the CI environment variable to enable the "show warning as errors" in Kotlin compiler

Motivation

During development, especially when doing TDD, I often find myself having variables/parameters temporarily unused, which prevent from running the tests.
This new option allows me to to TDD without manually changing the allWarningsAsErrors and still keep checks in the CI.

Note

The local_ci.sh script will set the environnement variable to ensure one can detect those warnings before pushing to CI

@xgouchet xgouchet requested a review from a team as a code owner October 9, 2023 10:22
@codecov-commenter
Copy link

Codecov Report

Merging #1664 (42dfa24) into develop (a340c76) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1664      +/-   ##
===========================================
- Coverage    83.64%   83.53%   -0.11%     
===========================================
  Files          458      458              
  Lines        15767    15764       -3     
  Branches      2354     2353       -1     
===========================================
- Hits         13187    13167      -20     
- Misses        1946     1969      +23     
+ Partials       634      628       -6     

see 18 files with indirect coverage changes

@xgouchet xgouchet merged commit b405b38 into develop Oct 9, 2023
5 checks passed
@xgouchet xgouchet deleted the xgouchet/disable_warning_as_errors_locally branch October 9, 2023 11:36
@xgouchet xgouchet added this to the 2.3.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants