RUM-891 Unit test to confirm SR records order is kept when having same timestamps #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusc83
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #1659 +/- ##
===========================================
- Coverage 83.86% 83.74% -0.12%
===========================================
Files 456 456
Lines 15692 15692
Branches 2346 2346
===========================================
- Hits 13160 13141 -19
- Misses 1922 1928 +6
- Partials 610 623 +13 |
0xnm
previously approved these changes
Oct 4, 2023
There was a problem hiding this comment.
minor: this file should be called BatchesToSegmentsMapperTest instead, because class under test is called BatchesToSegmentsMapper
mariusc83
force-pushed
the
mconstantin/rum-891/make-sure-the-order-is-kept-for-records-with-same-timestamp
branch
from
e8ef749 to
bd12c1e
Compare
0xnm
approved these changes
Oct 4, 2023
mariusc83
deleted the
mconstantin/rum-891/make-sure-the-order-is-kept-for-records-with-same-timestamp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We have situations where we have to send records with same timestamp (dummy records) when the view is changed to comply with the browser sdk - player way of working (FocusRecord, MetaRecord, ViewPortRecord) and we wanted to make sure that whenever they are read back from the batch to be sent the order is kept.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)