Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "RUM-1002 Implement base64 for imageviews" #1655

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

jonathanmos
Copy link
Member

@jonathanmos jonathanmos commented Oct 3, 2023

This reverts commit 3100b41.
Reverts base64 imageview support due to an issue discovered where the "content image" square size would change between when the image begins to download and finishes downloading remotely (the image is resized for centercrop). We will need to implement wireframe cropping and keep the image at a constant size.

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@jonathanmos jonathanmos requested a review from a team as a code owner October 3, 2023 11:08
@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Merging #1655 (e135321) into release/2.2.0 (c757420) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@                Coverage Diff                @@
##           release/2.2.0    #1655      +/-   ##
=================================================
- Coverage          83.86%   83.80%   -0.06%     
=================================================
  Files                456      457       +1     
  Lines              15692    15731      +39     
  Branches            2346     2348       +2     
=================================================
+ Hits               13160    13183      +23     
- Misses              1922     1924       +2     
- Partials             610      624      +14     
Files Coverage Δ
...adog/android/sessionreplay/SessionReplayPrivacy.kt 100.00% <100.00%> (ø)
...lay/internal/recorder/mapper/EditTextViewMapper.kt 100.00% <100.00%> (ø)
...play/internal/recorder/mapper/ImageButtonMapper.kt 93.55% <100.00%> (ø)

... and 16 files with indirect coverage changes

@jonathanmos jonathanmos merged commit 100edc9 into release/2.2.0 Oct 3, 2023
@jonathanmos jonathanmos deleted the jmoskovich/revert-base64-imageviews branch October 3, 2023 12:45
@xgouchet xgouchet added this to the 2.2.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants