RUM-1189 fix duplicate views in MixedViewTrackingStrategy #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xgouchet
force-pushed
the
xgouchet/RUM-1189/duplicate_views
branch
from
fae9dd4 to
3653664
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1639 +/- ##
===========================================
- Coverage 83.72% 83.64% -0.07%
===========================================
Files 456 456
Lines 15716 15695 -21
Branches 2340 2339 -1
===========================================
- Hits 13157 13128 -29
- Misses 1927 1941 +14
+ Partials 632 626 -6
|
mariusc83
approved these changes
Sep 26, 2023
| @@ -50,6 +48,8 @@ class MixedViewTrackingStrategy internal constructor( | |||
| ) | |||
| ) | |||
|
|
|||
| // region ActivityLifecycleTrackingStrategy | |||
|
|
|||
| override fun register(sdkCore: SdkCore, context: Context) { | |||
There was a problem hiding this comment.
I think this was brought with the sdk v2 as before we did not register the strategies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix #1614
Because the inner Activity and Fragment ViewTrackingStrategies used by the
MixedViewTrackingStrategyalso listen to activity lifecycle callbacks, RUM start view events are called twice, resulting in duplicated events.