RUM-1095 Fix the batch duration value in batch_close telemetry event #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariusc83
force-pushed
the
mconstantin/rum-1095/fix-batch-close-telemetry-data
branch
2 times, most recently
from
b815d63 to
96b6b65
Compare
0xnm
previously approved these changes
Sep 21, 2023
xgouchet
previously approved these changes
Sep 21, 2023
| return try { | ||
| dateTimeProvider.getDeviceTimestamp() - file.name.toLong() | ||
| this.name.toLong() |
There was a problem hiding this comment.
we could use .toLongOrNull() to avoid throwing an exception
There was a problem hiding this comment.
I wanted to have the exception just for us though...to see in case we have a weird filename in there. What do you think ?
There was a problem hiding this comment.
You can still log the filename when the result is null, but throwing an exception costs resources, it's more efficient to avoid it when we can
Codecov Report
@@ Coverage Diff @@
## develop #1633 +/- ##
===========================================
- Coverage 83.81% 83.79% -0.02%
===========================================
Files 455 455
Lines 15686 15684 -2
Branches 2331 2333 +2
===========================================
- Hits 13147 13142 -5
- Misses 1916 1918 +2
- Partials 623 624 +1
|
mariusc83
force-pushed
the
mconstantin/rum-1095/fix-batch-close-telemetry-data
branch
from
96b6b65 to
4654c0a
Compare
0xnm
previously approved these changes
Sep 22, 2023
jonathanmos
previously approved these changes
Sep 24, 2023
mariusc83
force-pushed
the
mconstantin/rum-1095/fix-batch-close-telemetry-data
branch
2 times, most recently
from
98ff93d to
2450355
Compare
0xnm
reviewed
Sep 26, 2023
| @@ -47,7 +48,7 @@ internal class BatchMetricsDispatcher( | |||
| } | |||
|
|
|||
| override fun sendBatchClosedMetric(batchFile: File, batchMetadata: BatchClosedMetadata) { | |||
| if (trackName == null || !sampler.sample()) { | |||
| if (!batchFile.existsSafe(internalLogger) || trackName == null || !sampler.sample()) { | |||
There was a problem hiding this comment.
small performance gain - let's put the check if file exists to the right - this way we won't do it if metric is not sampled, we are saving some I/O capacity and block the thread less
Suggested change
| if (!batchFile.existsSafe(internalLogger) || trackName == null || !sampler.sample()) { | |
| if (trackName == null || !sampler.sample() || !batchFile.existsSafe(internalLogger)) { |
jonathanmos
previously approved these changes
Sep 26, 2023
mariusc83
force-pushed
the
mconstantin/rum-1095/fix-batch-close-telemetry-data
branch
from
2450355 to
876f439
Compare
0xnm
approved these changes
Sep 26, 2023
mariusc83
deleted the
mconstantin/rum-1095/fix-batch-close-telemetry-data
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before we were computing the batch duration value for the
batch_closetelemetry event as:System.currentTimeInMillis - lastTimeBatchWasAccessedwhich was completely wrong. In this PR we are addressing this issue.Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)