RUM-985 fix the WebView fragment in sample app #1627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
approved these changes
Sep 20, 2023
Codecov Report
@@ Coverage Diff @@
## xgouchet/RUM-985/2_use_native_sampling_webview_rum #1627 +/- ##
======================================================================================
- Coverage 83.73% 83.59% -0.15%
======================================================================================
Files 452 452
Lines 15664 15664
Branches 2330 2330
======================================================================================
- Hits 13116 13093 -23
- Misses 1930 1952 +22
- Partials 618 619 +1 |
mariusc83
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A quick fix for the Webview page in the sample app: it would crash systematically because it used a generic ViewModelFactory instead of the app's one which can generate a WebviewViewModel.