Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTG-7 Use shared Android Lint check #1608

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Conversation

xgouchet
Copy link
Member

@xgouchet xgouchet commented Sep 8, 2023

What does this PR do?

Use a shared Android Lint check from dd-source

Motivation

Shared CI steps across all Android projects

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@xgouchet xgouchet requested a review from a team as a code owner September 8, 2023 07:48
0xnm
0xnm previously approved these changes Sep 8, 2023
mariusc83
mariusc83 previously approved these changes Sep 8, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Merging #1608 (f4f4769) into develop (b8c9f06) will decrease coverage by 0.09%.
Report is 3 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1608      +/-   ##
===========================================
- Coverage    83.61%   83.53%   -0.09%     
===========================================
  Files          451      451              
  Lines        15563    15563              
  Branches      2318     2318              
===========================================
- Hits         13013    12999      -14     
- Misses        1930     1941      +11     
- Partials       620      623       +3     

see 24 files with indirect coverage changes

@xgouchet xgouchet dismissed stale reviews from mariusc83 and 0xnm via 22d5daf September 8, 2023 09:16
@xgouchet xgouchet requested review from 0xnm and mariusc83 September 8, 2023 09:37
@xgouchet xgouchet merged commit d8b3962 into develop Sep 11, 2023
@xgouchet xgouchet deleted the xgouchet/MTG-7/android_lint branch September 11, 2023 07:43
@xgouchet xgouchet added this to the 2.2.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants