Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android Studio 'Rebuild Project' #1602

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

xgouchet
Copy link
Member

@xgouchet xgouchet commented Sep 6, 2023

What does this PR do?

Android Studio's Rebuild Project button performs the equivalent of ./gradlew clean assemble. Because of that the genDir folder used to store json2kotlin generated files is cleared and doesn't exists when the GenerateApiSurfaceTaskis ran.

The recommended way is to store path instead of actual files when the file is not guaranteed to exists when the task is ran.

Motivation

Being able to use the Rebuild Project feature in AS.

@xgouchet xgouchet requested a review from a team as a code owner September 6, 2023 11:53
@codecov-commenter
Copy link

Codecov Report

Merging #1602 (cea3775) into develop (bf9b6c3) will decrease coverage by 0.13%.
Report is 28 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1602      +/-   ##
===========================================
- Coverage    83.58%   83.45%   -0.13%     
===========================================
  Files          443      443              
  Lines        15122    15122              
  Branches      2264     2264              
===========================================
- Hits         12639    12620      -19     
- Misses        1885     1896      +11     
- Partials       598      606       +8     

see 20 files with indirect coverage changes

@xgouchet xgouchet merged commit e79eb19 into develop Sep 6, 2023
@xgouchet xgouchet deleted the xgouchet/fix_AS_rebuild branch September 6, 2023 12:31
@xgouchet xgouchet added this to the 2.2.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants