Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unregister process lifecycle monitor in core instance stop #1589

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Unregister process lifecycle monitor in core instance stop #1589

merged 1 commit into from
Aug 25, 2023

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Aug 25, 2023

What does this PR do?

Minor improvement: SDK instance can be stopped, so we should unregister process lifecycle monitor.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner August 25, 2023 12:50
@mariusc83 mariusc83 merged commit 9b9a19c into develop Aug 25, 2023
@mariusc83 mariusc83 deleted the nogorodnikov/unregister-process-lifecycle-monitor-in-core-instance-stop branch August 25, 2023 13:08
@xgouchet xgouchet added this to the 2.1.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusc83 mariusc83 mariusc83 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@0xnm @mariusc83 @xgouchet