Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-3508 Add the additionalProperties capability to telemetry debug log event #1575

Conversation

mariusc83
Copy link
Member

@mariusc83 mariusc83 commented Aug 11, 2023

What does this PR do?

Following up on the the latest changes on the telemetry events schema we are adding the capability to add additional properties as a Map<String,Any?> to our Telemetry debug log events.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 force-pushed the mconstantin/rumm-3508/add-additional-properties-for-telemetry-events branch 4 times, most recently from 07c3c39 to 2871266 Compare August 11, 2023 14:31
@mariusc83 mariusc83 marked this pull request as ready for review August 11, 2023 14:32
@mariusc83 mariusc83 requested a review from a team as a code owner August 11, 2023 14:32
@mariusc83 mariusc83 force-pushed the mconstantin/rumm-3508/add-additional-properties-for-telemetry-events branch 3 times, most recently from 3377375 to 5edfc85 Compare August 14, 2023 07:23
@mariusc83 mariusc83 force-pushed the mconstantin/rumm-3508/add-additional-properties-for-telemetry-events branch from 5edfc85 to 848b519 Compare August 14, 2023 07:57
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2023

Codecov Report

Merging #1575 (848b519) into develop (3d566c0) will decrease coverage by 0.02%.
The diff coverage is 91.43%.

@@             Coverage Diff             @@
##           develop    #1575      +/-   ##
===========================================
- Coverage    83.27%   83.25%   -0.02%     
===========================================
  Files          437      437              
  Lines        14763    14810      +47     
  Branches      2223     2226       +3     
===========================================
+ Hits         12293    12329      +36     
- Misses        1881     1891      +10     
- Partials       589      590       +1     
Files Changed Coverage Δ
...om/datadog/android/telemetry/internal/Telemetry.kt 15.38% <0.00%> (-4.62%) ⬇️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 76.28% <87.50%> (-0.38%) ⬇️
...n/kotlin/com/datadog/android/api/InternalLogger.kt 100.00% <100.00%> (ø)
...tlin/com/datadog/android/core/SdkInternalLogger.kt 89.16% <100.00%> (-3.05%) ⬇️
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.81% <100.00%> (+1.06%) ⬆️
...g/android/rum/internal/domain/scope/RumRawEvent.kt 100.00% <100.00%> (ø)
.../android/rum/internal/monitor/DatadogRumMonitor.kt 88.16% <100.00%> (+1.53%) ⬆️

... and 15 files with indirect coverage changes

@mariusc83 mariusc83 merged commit beb5ed1 into develop Aug 16, 2023
@mariusc83 mariusc83 deleted the mconstantin/rumm-3508/add-additional-properties-for-telemetry-events branch August 16, 2023 12:04
@xgouchet xgouchet added this to the 2.1.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants