Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REPLAY-1894: Remove explicit dependency on RUM module from Session Replay #1541

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jul 13, 2023

What does this PR do?

We were using just few symbols from RUM module, and they probably even are not needed.

This change is to have the consistency in the setup with iOS SDK, where DatadogRUM should be added alongside with Session Replay module.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner July 13, 2023 12:31
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #1541 (8fe4d3e) into develop (a0b843c) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1541      +/-   ##
===========================================
+ Coverage    83.41%   83.47%   +0.06%     
===========================================
  Files          438      438              
  Lines        14872    14877       +5     
  Branches      2242     2246       +4     
===========================================
+ Hits         12405    12418      +13     
+ Misses        1881     1877       -4     
+ Partials       586      582       -4     
Impacted Files Coverage Δ
...oid/rum/tracking/NavigationViewTrackingStrategy.kt 86.49% <100.00%> (+0.98%) ⬆️
...lay/internal/domain/SessionReplayRequestFactory.kt 98.08% <100.00%> (ø)

... and 13 files with indirect coverage changes

@0xnm 0xnm merged commit 8d1f9ab into develop Jul 17, 2023
@0xnm 0xnm deleted the nogorodnikov/replay-1894/remove-dependency-on-rum-from-session-replay branch July 17, 2023 07:47
@xgouchet xgouchet added this to the 2.0.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants