Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SR always listens and reacts to RUM session state #1539

Merged

Conversation

mariusc83
Copy link
Member

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@mariusc83 mariusc83 self-assigned this Jul 13, 2023
@mariusc83 mariusc83 requested a review from a team as a code owner July 13, 2023 09:06
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #1539 (18011ee) into develop (6118490) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1539      +/-   ##
===========================================
- Coverage    83.44%   83.40%   -0.04%     
===========================================
  Files          438      438              
  Lines        14867    14872       +5     
  Branches      2239     2242       +3     
===========================================
- Hits         12405    12403       -2     
- Misses        1873     1885      +12     
+ Partials       589      584       -5     
Impacted Files Coverage Δ
...droid/rum/internal/domain/scope/RumSessionScope.kt 95.40% <100.00%> (+1.22%) ⬆️
...oid/sessionreplay/internal/SessionReplayFeature.kt 100.00% <100.00%> (ø)

... and 17 files with indirect coverage changes

Copy link
Member

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariusc83 mariusc83 merged commit a0b843c into develop Jul 13, 2023
@mariusc83 mariusc83 deleted the mconstantin/sr-always-reacts-on-rum-session-state branch July 13, 2023 10:35
@xgouchet xgouchet added this to the 2.0.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants