Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-3445: Support navHost hosted by FragmentContainerView for NavigationViewTrackingStrategy #1538

Conversation

0xnm
Copy link
Member

@0xnm 0xnm commented Jul 12, 2023

What does this PR do?

This PR addresses the issue described here. Basically now the recommendation is to use FragmentContainerView for hosting NavHostFragment, this now will be the priority for lookup, and if not found we fall back to the old strategy.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@0xnm 0xnm requested a review from a team as a code owner July 12, 2023 15:58
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #1538 (e79517c) into develop (efac9da) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1538      +/-   ##
===========================================
- Coverage    83.45%   83.42%   -0.03%     
===========================================
  Files          438      438              
  Lines        14867    14872       +5     
  Branches      2239     2243       +4     
===========================================
  Hits         12406    12406              
  Misses        1879     1879              
- Partials       582      587       +5     
Impacted Files Coverage Δ
...oid/rum/tracking/NavigationViewTrackingStrategy.kt 86.49% <100.00%> (+0.98%) ⬆️

... and 15 files with indirect coverage changes

@0xnm 0xnm merged commit 0c5a072 into develop Jul 13, 2023
@0xnm 0xnm deleted the nogorodnikov/rumm-3445/support-nav-host-wrapped-in-fragment-container-view branch July 13, 2023 12:14
@xgouchet xgouchet added this to the 2.0.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants