RUMM-3338: Introduce known file cache and cleanup throttling in BatchFileOrchestrator
in order to reduce the number of syscalls
#1506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The goal of this PR is to reduce CPU consumption during the scenarios like described in #1469.
The issue comes from the fact that when we have many batch files on the disk calling
listSortedBatchFiles
as-is (which is called several times duringgetWritableFile
, for example) becomes quite expensive because:isFile
) are expensiveIn order to optimize that, the following is done:
isFile
and use regex.getWritableFile
path, because a) it can be called much more often thangetReadableFile
, for every event; b) cleanup actions are a bit different betweengetReadableFile
andgetWritableFile
, so having the same timestamp is not quite correct).Test scenario: 300 batch files on the disk, disabled network, writing 1 log entry every 100 ms.
CPU usage after the change (same scenario and duration is used):
It gives a very good bump if the total number files on the disk is below the cache max size. If cache is not enough, the problem comes back (but maybe in a bit better state, because we have cleanup throttling)
CPU usage before the change:
Review checklist (to be filled by reviewers)