Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra telemetry sent when detecting refresh rate scale #1358

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

fuzzybinary
Copy link
Member

What does this PR do?

Removes a piece of telemetry we're seeing a lot of at the moment.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@fuzzybinary fuzzybinary requested a review from a team as a code owner March 28, 2023 20:32
@codecov-commenter
Copy link

codecov-commenter commented Mar 29, 2023

Codecov Report

Merging #1358 (788199f) into release/1.18.0 (4096fc0) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           release/1.18.0    #1358      +/-   ##
==================================================
- Coverage           81.99%   81.80%   -0.19%     
==================================================
  Files                 362      362              
  Lines               12903    12894       -9     
  Branches             2164     2164              
==================================================
- Hits                10579    10547      -32     
- Misses               1678     1682       +4     
- Partials              646      665      +19     
Impacted Files Coverage Δ
.../android/rum/internal/domain/scope/RumViewScope.kt 94.95% <ø> (+0.61%) ⬆️

... and 13 files with indirect coverage changes

@fuzzybinary fuzzybinary force-pushed the jward/remove-framerate-telemetry branch from 788199f to 2a179c3 Compare March 29, 2023 13:38
@fuzzybinary fuzzybinary requested review from xgouchet and 0xnm March 29, 2023 13:38
@fuzzybinary fuzzybinary merged commit e3b23a7 into release/1.18.0 Mar 29, 2023
@fuzzybinary fuzzybinary deleted the jward/remove-framerate-telemetry branch March 29, 2023 19:41
@xgouchet xgouchet added this to the 1.18.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants