Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix telemetry sampling internal configuration for Flutter #1326

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

fuzzybinary
Copy link
Member

What does this PR do?

Flutter sends the telemetry configuration sample rate as a Double, not a Float. Use Number instead.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@fuzzybinary fuzzybinary requested a review from a team as a code owner March 7, 2023 14:38
Flutter sends the telemetry configuration sample rate as a Double, not a Float. Use Number instead.
@fuzzybinary fuzzybinary force-pushed the jward/minor-telemetry-fix branch from 5db5979 to 5270ddd Compare March 8, 2023 15:18
@fuzzybinary fuzzybinary merged commit adea67d into develop Mar 8, 2023
@fuzzybinary fuzzybinary deleted the jward/minor-telemetry-fix branch March 8, 2023 16:11
@xgouchet xgouchet added this to the 1.18.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants