Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement webview proxy for cross platform #1290

Conversation

louiszawadzki
Copy link
Contributor

@louiszawadzki louiszawadzki commented Feb 17, 2023

What does this PR do?

Adds internal function to consume web view events for cross-platform SDKs

Additional Notes

image

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@louiszawadzki louiszawadzki force-pushed the louiszawadzki/rumm-3043/expose-webview-internals-for-cross-platform branch 2 times, most recently from 990c173 to e3357f8 Compare February 20, 2023 16:22
@louiszawadzki louiszawadzki marked this pull request as ready for review February 20, 2023 16:22
@louiszawadzki louiszawadzki requested a review from a team as a code owner February 20, 2023 16:22
@louiszawadzki louiszawadzki force-pushed the louiszawadzki/rumm-3043/expose-webview-internals-for-cross-platform branch from e3357f8 to f9dee9e Compare February 20, 2023 16:35
@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #1290 (f9dee9e) into develop (dde54aa) will increase coverage by 0.12%.
The diff coverage is 86.36%.

@@             Coverage Diff             @@
##           develop    #1290      +/-   ##
===========================================
+ Coverage    81.85%   81.97%   +0.12%     
===========================================
  Files          361      361              
  Lines        12835    12854      +19     
  Branches      2148     2151       +3     
===========================================
+ Hits         10506    10537      +31     
+ Misses        1665     1664       -1     
+ Partials       664      653      -11     
Impacted Files Coverage Δ
...oid/src/main/kotlin/com/datadog/android/Datadog.kt 77.36% <0.00%> (ø)
.../main/kotlin/com/datadog/android/_InternalProxy.kt 89.66% <90.48%> (+9.66%) ⬆️
...android/log/internal/logger/TelemetryLogHandler.kt 85.71% <0.00%> (-14.29%) ⬇️
...droid/rum/tracking/FragmentViewTrackingStrategy.kt 75.00% <0.00%> (-3.85%) ⬇️
...n/com/datadog/android/v2/core/SdkInternalLogger.kt 88.89% <0.00%> (-2.78%) ⬇️
...id/rum/internal/ndk/DatadogNdkCrashEventHandler.kt 91.00% <0.00%> (-2.00%) ⬇️
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.94% <0.00%> (ø)
.../android/rum/internal/monitor/DatadogRumMonitor.kt 89.42% <0.00%> (+0.53%) ⬆️
...ndroid/telemetry/internal/TelemetryEventHandler.kt 71.09% <0.00%> (+0.78%) ⬆️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 85.59% <0.00%> (+0.85%) ⬆️
... and 6 more

@louiszawadzki louiszawadzki merged commit 9edce6d into develop Feb 22, 2023
@louiszawadzki louiszawadzki deleted the louiszawadzki/rumm-3043/expose-webview-internals-for-cross-platform branch February 22, 2023 09:06
@xgouchet xgouchet added this to the 1.18.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants