Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated privacy controls in application setup #1281

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

rtrieu
Copy link
Contributor

@rtrieu rtrieu commented Feb 14, 2023

What does this PR do?

Describes a new config set up option for automatically collecting user data.

Motivation

DOCS-4882, which is a part of DOCS-4827.

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

@rtrieu rtrieu requested review from a team as code owners February 14, 2023 00:40
docs/rum_getting_started.md Outdated Show resolved Hide resolved

{{< img src="real_user_monitoring/android/create_rum_application.png" alt="Create a RUM application in Datadog workflow" style="width:90%;">}}
{{< img src="real_user_monitoring/android/new-rum-app-android-1.png" alt="Create a RUM application in Datadog workflow" style="width:90%;">}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get 404 when trying to open it using https://docs.datadoghq.com/real_user_monitoring/android/new-rum-app-android-1.png. The asset is not yet uploaded?

Copy link
Contributor Author

@rtrieu rtrieu Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just uploaded! Let me know if it doesn't show up.

Copy link
Contributor

@buraizu buraizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one optional suggestion

docs/rum_getting_started.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023

Codecov Report

Merging #1281 (b3ffe18) into develop (a9351e9) will increase coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1281      +/-   ##
===========================================
+ Coverage    81.85%   81.92%   +0.08%     
===========================================
  Files          361      361              
  Lines        12835    12835              
  Branches      2148     2148              
===========================================
+ Hits         10505    10515      +10     
- Misses        1664     1671       +7     
+ Partials       666      649      -17     
Impacted Files Coverage Δ
...com/datadog/opentracing/propagation/HttpCodec.java 38.24% <0.00%> (-8.82%) ⬇️
.../datadog/opentracing/propagation/W3CHttpCodec.java 0.00% <0.00%> (-5.17%) ⬇️
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 81.54% <0.00%> (-1.54%) ⬇️
...android/v2/core/internal/net/DataOkHttpUploader.kt 94.94% <0.00%> (ø)
.../android/rum/internal/domain/scope/RumViewScope.kt 95.68% <0.00%> (+0.18%) ⬆️
.../android/rum/internal/monitor/DatadogRumMonitor.kt 89.42% <0.00%> (+0.53%) ⬆️
...ain/java/com/datadog/opentracing/PendingTrace.java 60.34% <0.00%> (+0.86%) ⬆️
...al/persistence/file/batch/BatchFileOrchestrator.kt 95.28% <0.00%> (+1.57%) ⬆️
...id/rum/internal/ndk/DatadogNdkCrashEventHandler.kt 90.00% <0.00%> (+2.00%) ⬆️
...in/com/datadog/android/log/internal/LogsFeature.kt 88.46% <0.00%> (+4.62%) ⬆️
... and 2 more

rtrieu and others added 2 commits March 9, 2023 15:31
Co-authored-by: Bryce Eadie <bryce.eadie@datadoghq.com>
@rtrieu rtrieu changed the title updated content Updated privacy controls in application setup Mar 9, 2023
@rtrieu rtrieu merged commit a2488e4 into develop Mar 9, 2023
@rtrieu rtrieu deleted the rtrieu/docs-4882-new-nav branch March 9, 2023 23:39
@xgouchet xgouchet added this to the 1.18.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants