Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUMM-2864 add support to AP1 #1268

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

xgouchet
Copy link
Member

@xgouchet xgouchet commented Feb 7, 2023

What does this PR do?

Adds support to the AP1 (Japan) datacenter

Additional Notes

We also use subdomainless endpoints, which are not necessary since API v2 where the track is part of the path.

@xgouchet xgouchet requested a review from a team as a code owner February 7, 2023 09:45
Copy link
Member

@0xnm 0xnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I like the change to switch to remove feature-specific intakes.

@xgouchet xgouchet force-pushed the xgouchet/RUMM-2864/support_ap1 branch from c98587a to db007d7 Compare February 7, 2023 12:54
@codecov-commenter
Copy link

Codecov Report

Merging #1268 (db007d7) into develop (31b0121) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1268      +/-   ##
===========================================
- Coverage    82.01%   81.99%   -0.02%     
===========================================
  Files          361      361              
  Lines        12832    12820      -12     
  Branches      2149     2146       -3     
===========================================
- Hits         10524    10511      -13     
- Misses        1655     1656       +1     
  Partials       653      653              
Impacted Files Coverage Δ
...main/kotlin/com/datadog/android/DatadogEndpoint.kt 0.00% <ø> (ø)
...src/main/kotlin/com/datadog/android/DatadogSite.kt 100.00% <100.00%> (ø)
...atadog/android/core/configuration/Configuration.kt 98.13% <100.00%> (ø)
.../datadog/android/sessionreplay/utils/ThemeUtils.kt 83.33% <0.00%> (-16.67%) ⬇️
...rsistence/file/batch/PlainBatchFileReaderWriter.kt 81.54% <0.00%> (-1.54%) ⬇️
...lin/com/datadog/android/rum/internal/RumFeature.kt 92.09% <0.00%> (-1.44%) ⬇️
...ain/java/com/datadog/opentracing/PendingTrace.java 59.48% <0.00%> (-0.86%) ⬇️
.../kotlin/com/datadog/android/v2/core/DatadogCore.kt 85.59% <0.00%> (-0.42%) ⬇️
.../android/rum/internal/domain/scope/RumViewScope.kt 95.45% <0.00%> (ø)
...in/com/datadog/android/log/internal/LogsFeature.kt 86.92% <0.00%> (+1.54%) ⬆️
... and 2 more

@xgouchet xgouchet merged commit af16265 into develop Feb 7, 2023
@xgouchet xgouchet deleted the xgouchet/RUMM-2864/support_ap1 branch February 7, 2023 14:15
@xgouchet xgouchet added this to the 1.18.0 milestone Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants